This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] Fix workspace of BoxNMS #20212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ptrendx , Thanks for submitting the PR
CI supported jobs: [sanity, clang, centos-gpu, centos-cpu, windows-gpu, miscellaneous, unix-cpu, windows-cpu, edge, website, unix-gpu] Note: |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [centos-cpu, centos-gpu, unix-gpu] |
|
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, unix-gpu] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
mseth10
added
pr-awaiting-testing
|
@mxnet-bot run ci [centos-cpu] |
|
Jenkins CI successfully triggered : [centos-cpu] |
mseth10
added
pr-awaiting-testing
DickJC123
approved these changes
Apr 27, 2021
chinakook
pushed a commit
to chinakook/mxnet
that referenced
this pull request
May 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes 2 problems:
uint8_t, the maximum workspace size without setting large tensor support was 2GB, which was too small for some cases, without any error reporting (going over that limit would make the index_t in Shape1 overflow, resulting in negative value, which would later be cast to size_t in the allocator and MXNet would try to allocate a huge amount of memory, resulting in OoM). This PR changes the type of the allocation to double so that the size limit for workspace rises to 16 GB when large tensor support is not enabled.Checklist
Essentials